repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
facebook/react
9a2591681e8da73da35c1116c0087d9c309afa2a
4a8deb08367d93d51912871b6d0e62852d0e981a
Fix export
[ { "path": "packages/react-server-dom-relay/src/ReactServerStreamConfigFB.js", "patch": "@@ -17,6 +17,8 @@ export type Destination = {\n export type PrecomputedChunk = string;\n export type Chunk = string;\n \n+export const isPrimaryStreamConfig = true;\n+\n export function scheduleWork(callback: () => void)...
2021-04-27T13:44:17
vercel/next.js
5537946e085e0d3ed44054334ab38612069eaa60
a840415e458515fa1122dba87f83abe609a0514e
[Turbopack] add more options for production chunking (#75544) add more options for production chunking adjust chunking options <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose t...
[ { "path": "crates/next-core/src/next_client/context.rs", "patch": "@@ -449,7 +449,9 @@ pub async fn get_client_chunking_context(\n builder = builder.hot_module_replacement().use_file_source_map_uris();\n } else {\n builder = builder.ecmascript_chunking_config(ChunkingConfig {\n- ...
2025-02-03T14:38:51
golang/go
f71c00b6165177dbcc5d40ff5f4731d297ee6090
d3c93f2f00fe40eb6f8b0bf9c81b15ddd9872119
cmd/link: align .reloc block starts by 32 bits for PE target Tweak the code that emits the PE ".reloc" section on Windows to ensure that each relocation block is 32-bit aligned, which is required by the PE standard. Fixes #68260. Change-Id: I39b75a7491b00fa97871aebb90d3be0ec09f9c40 Reviewed-on: https://go-review.goo...
[ { "path": "src/cmd/link/internal/ld/pe.go", "patch": "@@ -1548,8 +1548,21 @@ func (rt *peBaseRelocTable) write(ctxt *Link) {\n \t// sort the pages array\n \tsort.Sort(rt.pages)\n \n+\t// .reloc section must be 32-bit aligned\n+\tif out.Offset()&3 != 0 {\n+\t\tErrorf(nil, \"internal error, start of .reloc no...
2024-07-01T16:11:33
nodejs/node
adf332be32a32120b2d4bcac2efe6ad8f9a6d37d
c9683618296fae63a5f6253dd5d1ea3b00a51d89
assert: deprecate callTracker PR-URL: https://github.com/nodejs/node/pull/47740 Fixes: https://github.com/nodejs/node/issues/47492 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "doc/api/assert.md", "patch": "@@ -221,11 +221,18 @@ try {\n added:\n - v14.2.0\n - v12.19.0\n+changes:\n+ - version: REPLACEME\n+ pr-url: https://github.com/nodejs/node/pull/47740\n+ description: the `assert.CallTracker` class has been deprecated and will be\n+ removed...
2023-04-29T06:57:08
facebook/react
9cd52b27fe7be3c320d1e94a016fc416e66569b1
ad091759a949747f55e1bad498d19be884d4a654
Restore context after an error happens (#21341) Typically we don't need to restore the context here because we assume that we'll terminate the rest of the subtree so we don't need the correct context since we're not rendering any siblings. However, after a nested suspense boundary we need to restore the context. ...
[ { "path": "packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js", "patch": "@@ -796,6 +796,73 @@ describe('ReactDOMFizzServer', () => {\n );\n });\n \n+ // @gate experimental\n+ it('should recover the outer context when an error happens inside a provider', async () => {\n+ const ContextA =...
2021-04-23T19:24:10
electron/electron
272611cc825459725f8a356c1732a1bbeb011a82
b6df7cd327e9102f3d994124f5f12e4de4b8a424
docs: Update ipcMain.handle() docs in ipc-main.md for error-handling details (#27461) * Update ipc-main.md Include information about ipcMain.handle() error handling and workaround included in issue #24427 * Update ipc-main.md fixed a typo * Update ipc-main.md Remove the exception passing workaround from...
[ { "path": "docs/api/ipc-main.md", "patch": "@@ -120,6 +120,11 @@ The `event` that is passed as the first argument to the handler is the same as\n that passed to a regular event listener. It includes information about which\n WebContents is the source of the invoke request.\n \n+Errors thrown through `handle...
2021-02-02T12:22:20
vercel/next.js
a840415e458515fa1122dba87f83abe609a0514e
f1f85183d751d4d89f415414a37b53cbbcb6f60a
Update test-junit-report path (#75612) Updates the last path that is incorrect. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that ...
[ { "path": ".github/workflows/rspack-nextjs-build-integration-tests.yml", "patch": "@@ -149,7 +149,7 @@ jobs:\n name: test-reports-build-integration-${{ matrix.group }}\n if-no-files-found: 'error'\n path: |\n- test/turbopack-test-junit-report\n+ test/rspac...
2025-02-03T14:37:14
golang/go
cdbf5f2f7e968993560730479d4670c2d6eecd8b
c33144c47cbee5506df404553c3769867972f889
sync: refer to Locker interface methods in RWMutex.RLocker doc The methods being implemented are part of the Locker interface, not the RWMutex struct. Fixes #68250. Change-Id: I609c4d5c44e90a12914a8678971ba295519cc265 Reviewed-on: https://go-review.googlesource.com/c/go/+/595875 Auto-Submit: Dmitri Shuralyov <dmitsh...
[ { "path": "src/sync/rwmutex.go", "patch": "@@ -234,7 +234,7 @@ func syscall_hasWaitingReaders(rw *RWMutex) bool {\n }\n \n // RLocker returns a [Locker] interface that implements\n-// the [RWMutex.Lock] and [RWMutex.Unlock] methods by calling rw.RLock and rw.RUnlock.\n+// the [Locker.Lock] and [Locker.Unloc...
2024-06-29T20:35:40
nodejs/node
c9683618296fae63a5f6253dd5d1ea3b00a51d89
22ec1ddb86324fc49c889bbd7a137869201341dd
doc: fix typo in webstreams.md PR-URL: https://github.com/nodejs/node/pull/47766 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
[ { "path": "doc/api/webstreams.md", "patch": "@@ -1464,7 +1464,7 @@ added: v16.7.0\n contents of the stream.\n \n ```mjs\n-import { buffer as arrayBuffer } from 'node:stream/consumers';\n+import { arrayBuffer } from 'node:stream/consumers';\n import { Readable } from 'node:stream';\n import { TextEncoder }...
2023-04-28T22:53:28
rust-lang/rust
6da10482364d1159ecff4b9eb11443852fbe9586
fcdea4d66379c69c2d3710afda2bccef3b88e597
Fix some divergences with the cg_clif subtree For some reason git-subtree incorrectly synced those changes.
[ { "path": "src/intrinsics/simd.rs", "patch": "@@ -1005,14 +1005,6 @@ pub(super) fn codegen_simd_intrinsic_call<'tcx>(\n let lane_clif_ty = fx.clif_type(val_lane_ty).unwrap();\n let ret_lane_layout = fx.layout_of(ret_lane_ty);\n \n- let alignment =\n- generic...
2025-12-24T12:25:30
facebook/react
af5037a7a8ee983337a08eeff7477656bd80f5ec
e8cdce40d667fa6745c9412b764c65eb85435b97
[Fizz] Wire up the Fixture (#21273) * Wire up fizz to fixture * Fixed typo conditional
[ { "path": "fixtures/ssr/server/index.js", "patch": "@@ -21,12 +21,12 @@ if (process.env.NODE_ENV === 'development') {\n delete require.cache[key];\n }\n const render = require('./render').default;\n- res.send(render(req.url));\n+ render(req.url, res);\n });\n } else {\n const render ...
2021-04-22T22:00:35
electron/electron
b6df7cd327e9102f3d994124f5f12e4de4b8a424
20a71be849b7822af60a189b870b8c8ed9f04796
fix: crash when loadExtension fails (#27561)
[ { "path": "shell/browser/extensions/electron_extension_loader.cc", "patch": "@@ -112,22 +112,22 @@ void ElectronExtensionLoader::FinishExtensionLoad(\n scoped_refptr<const Extension> extension = result.first;\n if (extension) {\n extension_registrar_.AddExtension(extension);\n- }\n \n- // Write ex...
2021-02-02T10:20:05
golang/go
c33144c47cbee5506df404553c3769867972f889
82c371a307116450e9ab4dbce1853da3e69f4061
runtime: fix nil pointer in TestGoroutineParallelism2 when offline Previously, the test would crash when running on a computer without an internet connection, e.g. in airplane mode (stack trace below). The bug was that the condition was inverted. The code tried to close the listener if `err != nil` (that is, if net.L...
[ { "path": "src/runtime/proc_test.go", "patch": "@@ -200,7 +200,7 @@ func testGoroutineParallelism2(t *testing.T, load, netpoll bool) {\n \t\t\t\tladdr = \"127.0.0.1:0\"\n \t\t\t}\n \t\t\tln, err := net.Listen(\"tcp\", laddr)\n-\t\t\tif err != nil {\n+\t\t\tif err == nil {\n \t\t\t\tdefer ln.Close() // yup, ...
2024-05-13T04:10:34
vercel/next.js
8a2b3818375d8dc5b0cb31c5da41eb72ac53d132
b231c0c8eb9510d5a85413ded61febe7f0587bcd
[Turbopack] update event_listener to fix hanging bug (#75481) ### What? It has a bug about pinning...
[ { "path": "Cargo.lock", "patch": "@@ -420,7 +420,7 @@ version = \"3.4.0\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n checksum = \"ff6e472cdea888a4bd64f342f09b3f50e1886d32afe8df3d663c01140b811b18\"\n dependencies = [\n- \"event-listener 5.3.1\",\n+ \"event-listener 5.4.0\",\n \"e...
2025-02-03T12:16:56
nodejs/node
212821afdd8f20bb4c4fc1045178c5cee8b33de5
11233777917e7d5b73a8e9846b6a5308c69e8d30
deps: V8: cherry-pick c5ab3e4f0c5a Original commit message: libstdc++: fix incomplete type in v8::internal::is_subtype<T, U> Using std::convertible with incomplete types is UB. However, till GCC 12 it was accepted and std::convertible returned false. This fails now for e.g. v8::internal::WasmArray. U...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.4',\n+ 'v8_embedder_string': '-node.5',\n \n ##### V8 defaults for Node.js #####\n "...
2023-04-28T19:58:09
rust-lang/rust
a8c9cb5f77f2d66f85758703610b55a2ae8865e0
efa32de15b394620520f24781d8c55d4df6fa106
Fix some divergences with the cg_clif subtree For some reason git-subtree incorrectly synced those changes.
[ { "path": "compiler/rustc_codegen_cranelift/src/intrinsics/simd.rs", "patch": "@@ -1005,14 +1005,6 @@ pub(super) fn codegen_simd_intrinsic_call<'tcx>(\n let lane_clif_ty = fx.clif_type(val_lane_ty).unwrap();\n let ret_lane_layout = fx.layout_of(ret_lane_ty);\n \n- let alig...
2025-12-24T12:25:30
facebook/react
a1558600183b4321d4cdc117925980f1865641fa
89847bf6e6c0b77ced5dfc7b794c730bb3deac36
Fix: Don't flush discrete at end of batchedUpdates (#21229) The outermost `batchedUpdates` call flushes pending sync updates at the end. This was intended for legacy sync mode, but it also happens to flush discrete updates in concurrent mode. Instead, we should only flush sync updates at the end of `batchedUpdat...
[ { "path": "packages/react-devtools-shared/src/__tests__/storeStressTestConcurrent-test.js", "patch": "@@ -11,6 +11,7 @@ describe('StoreStressConcurrent', () => {\n let React;\n let ReactDOM;\n let act;\n+ let actAsync;\n let bridge;\n let store;\n let print;\n@@ -23,6 +24,9 @@ describe('StoreSt...
2021-04-21T16:32:09
electron/electron
8bf66f8974c6dc0aecdc22e4ddce2881e1836840
6edf6c6a957e4f2c2d1f2bdd4ddb7d39ecacc37e
fix: clean up implementations of titleBarStyle (#27489) * Rewrite titleBarStyle impls with WindowButtonsView * Remove fullscreenWindowTitle option * Make buttons show correctly under RTL * Fix docs about traffic lights position * Fix test on fullscreen resizable * Fix button states with closabe/minimiza...
[ { "path": "docs/api/browser-window.md", "patch": "@@ -222,16 +222,14 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.\n the top left.\n * `hiddenInset` - Results in a hidden title bar with an alternative look\n where the traffic light buttons are slightly m...
2021-01-30T23:15:10
vercel/next.js
b231c0c8eb9510d5a85413ded61febe7f0587bcd
4e3946084236bc818f40cd011652fef5d6671e38
Add package.json script for building turbopack-cli (#75031) ## What? Makes it easier to run the build for the version of Turbopack we use for benchmarking. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow th...
[ { "path": "package.json", "patch": "@@ -64,6 +64,7 @@\n \"unpack-next\": \"node scripts/unpack-next.cjs\",\n \"swc-build-native\": \"node scripts/build-native.cjs\",\n \"swc-build-wasm\": \"node scripts/build-wasm.cjs\",\n+ \"build-turbopack-cli\": \"cargo build -p turbopack-cli --release\",\...
2025-02-03T11:24:14
golang/go
82c371a307116450e9ab4dbce1853da3e69f4061
773767def0e0f29584a69bd760430167b7479d7d
cmd/compile: drop internal range-over-func vars from DWARF output Drops internal range-over-func variables from the DWARF output (excluding #yield which is used by Delve). Fixes #68238 Change-Id: Ic035e37ca3560347276cdc3b469fd564da33f4f5 Reviewed-on: https://go-review.googlesource.com/c/go/+/594257 Reviewed-by: Than...
[ { "path": "src/cmd/compile/internal/dwarfgen/dwarf.go", "patch": "@@ -91,6 +91,9 @@ func Info(fnsym *obj.LSym, infosym *obj.LSym, curfn obj.Func) (scopes []dwarf.Sc\n \t\t\tdefault:\n \t\t\t\tcontinue\n \t\t\t}\n+\t\t\tif !ssa.IsVarWantedForDebug(n) {\n+\t\t\t\tcontinue\n+\t\t\t}\n \t\t\tapdecls = append(ap...
2024-06-24T13:53:55
rust-lang/rust
5c99ebf42c004696e8dbae8c24dd481d00f180f0
1ed00f39c22428dce3f6162cc1e803b82b6b76e5
Fix indent for convert_to_guarded_return
[ { "path": "src/tools/rust-analyzer/crates/ide-assists/src/handlers/convert_to_guarded_return.rs", "patch": "@@ -218,7 +218,7 @@ fn let_stmt_to_guarded_return(\n let let_else_stmt = make::let_else_stmt(\n happy_pattern,\n let_stmt.ty(),\n- ...
2025-12-24T13:46:57
facebook/react
89847bf6e6c0b77ced5dfc7b794c730bb3deac36
ef37d55b68ddc45d465b84ea2ce30e8328297b2d
Continuous updates should interrupt transitions (#21323) Even when updates are sync by default. Discovered this quirk while working on #21322. Previously, when sync default updates are enabled, continuous updates are treated like default updates. We implemented this by assigning DefaultLane to continous updates....
[ { "path": "packages/react-reconciler/src/ReactFiberLane.new.js", "patch": "@@ -39,6 +39,7 @@ import {\n enableCache,\n enableSchedulingProfiler,\n enableUpdaterTracking,\n+ enableSyncDefaultUpdates,\n } from 'shared/ReactFeatureFlags';\n import {isDevToolsPresent} from './ReactFiberDevToolsHook.new';...
2021-04-21T15:51:04
nodejs/node
1baf96aeb88680bb89b1903b97a574b13e1674ab
b31d587dc8c1b0f459243d2b96a17a7175c996cf
doc,test: fix concurrency option of test() The documentation appears to still be wrong w.r.t. the meaning of the concurrency option of the test() function. The implementation appears to default to Infinity when the option is set to true. Is that intended or a good idea? I don't know. It certainly makes more sense than...
[ { "path": "doc/api/test.md", "patch": "@@ -808,9 +808,8 @@ changes:\n properties are supported:\n * `concurrency` {number|boolean} If a number is provided,\n then that many tests would run in parallel within the application thread.\n- If `true`, it would run `os.availableParallelism() - 1` tests ...
2023-04-28T18:32:08
electron/electron
6edf6c6a957e4f2c2d1f2bdd4ddb7d39ecacc37e
79b33937688a6745b7813364bfc732b8084d26d1
fix: pass button callback in constructor (#27545)
[ { "path": "shell/browser/ui/views/menu_bar.cc", "patch": "@@ -167,7 +167,7 @@ bool MenuBar::AcceleratorPressed(const ui::Accelerator& accelerator) {\n \n if (keycode == accelerator.key_code()) {\n auto event = accelerator.ToKeyEvent();\n- ButtonPressed(button, event);\n+ ...
2021-01-29T20:43:51
golang/go
773767def0e0f29584a69bd760430167b7479d7d
7f90b960a9711b51bf36f49be4274ac5f7e86a95
net/http: avoid appending an existing trailing slash to path again This CL is similar to CL 562557, and it takes over CL 594175. While here, unrelatedly remove mapKeys function, use slices.Sorted(maps.Keys(ms)) to simplify code. Fixes #67657 Change-Id: Id8b99216f87a6dcfd6d5fa61407b515324c79112 Reviewed-on: https://...
[ { "path": "src/net/http/routing_tree_test.go", "patch": "@@ -7,6 +7,7 @@ package http\n import (\n \t\"fmt\"\n \t\"io\"\n+\t\"maps\"\n \t\"strings\"\n \t\"testing\"\n \n@@ -261,9 +262,7 @@ func TestMatchingMethods(t *testing.T) {\n \t\tt.Run(test.name, func(t *testing.T) {\n \t\t\tms := map[string]bool{}\n ...
2024-06-25T17:35:13
facebook/react
ef37d55b68ddc45d465b84ea2ce30e8328297b2d
a632f7de3bd35eaf6d5082054af4da92dd37cf20
Use performConcurrentWorkOnRoot for "sync default" (#21322) Instead of `performSyncWorkOnRoot`. The conceptual model is that the only difference between sync default updates (in React 18) and concurrent default updates (in a future major release) is time slicing. All other behavior should be the same (i.e. the s...
[ { "path": "packages/react-reconciler/src/ReactFiberLane.new.js", "patch": "@@ -263,6 +263,9 @@ export function getNextLanes(root: FiberRoot, wipLanes: Lanes): Lanes {\n // Default priority updates should not interrupt transition updates. The\n // only difference between default updates and trans...
2021-04-21T15:29:31
vercel/next.js
4e3946084236bc818f40cd011652fef5d6671e38
7533f253840ab53ebd9381751370adbb74e873f9
Turbopack CI: Update test results artifact (#75429) ## What? Makes it easier to understand which test results are loaded. Mirrors the naming we use for production tests. No functional changes in this PR. Only updating the name. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sur...
[ { "path": ".github/workflows/turbopack-nextjs-dev-integration-tests.yml", "patch": "@@ -178,7 +178,7 @@ jobs:\n - name: Store artifacts\n uses: actions/upload-artifact@v4\n with:\n- name: test-results\n+ name: test-results-turbopack-development\n path: |\n ...
2025-02-03T11:23:00
nodejs/node
b31d587dc8c1b0f459243d2b96a17a7175c996cf
a75959b1bc978082f647da5f7138f299f9cd23d8
test_runner: support combining coverage reports This commit adds support for combining code coverage reports in the test runner. This allows coverage to be collected for child processes, and by extension, the test runner CLI. PR-URL: https://github.com/nodejs/node/pull/47686 Fixes: https://github.com/nodejs/node/issu...
[ { "path": "doc/api/cli.md", "patch": "@@ -624,6 +624,10 @@ Use this flag to enable [ShadowRealm][] support.\n added:\n - v19.7.0\n - v18.15.0\n+changes:\n+ - version: REPLACEME\n+ pr-url: https://github.com/nodejs/node/pull/47686\n+ description: This option can be used with `--test`.\n -->\n \n W...
2023-04-28T13:13:53
electron/electron
357becd11326dbf47c95e1973d53fec10591bea8
40aeb0d9949e3a9bfe5613f5543bb254222ca312
fix: replace default frameName title with null check (#27521) * refactor: replace default frameName title with null check * add isNativeWindowOpen check in makeBrowserWindowOptions * modify snapshot test files * replace title with frame-name again for proxy - not native open * modify proxy snapshot title k...
[ { "path": "lib/browser/guest-window-manager.ts", "patch": "@@ -47,6 +47,7 @@ export function openGuestWindow ({ event, embedder, guest, referrer, disposition\n embedder,\n features,\n frameName,\n+ isNativeWindowOpen,\n overrideOptions: overrideBrowserWindowOptions\n });\n \n@@ -199,10 ...
2021-01-29T13:24:30
facebook/react
bd7f4a013be3ef272a01874532bee71ad861e617
78120032d4ca7ee8611d630d7c67e7808885dfe9
Fix sloppy factoring in `performSyncWorkOnRoot` (#21246) * Warn if `finishedLanes` is empty in commit phase See #21233 for context. * Fix sloppy factoring when assigning finishedLanes `finishedLanes` is assigned in `performSyncWorkOnRoot` and `performSyncWorkOnRoot`. It's meant to represent whichever lanes w...
[ { "path": "packages/react-reconciler/src/ReactFiberLane.new.js", "patch": "@@ -614,12 +614,6 @@ export function markRootExpired(root: FiberRoot, expiredLanes: Lanes) {\n root.pendingLanes |= SyncLane;\n }\n \n-export function areLanesExpired(root: FiberRoot, lanes: Lanes) {\n- const SyncLaneIndex = 0;\n-...
2021-04-20T16:14:55
vercel/next.js
7533f253840ab53ebd9381751370adbb74e873f9
bcef4dd3b46487bf359581cb223be52f39ee7003
Fix rewrite-headers test (#75602)
[ { "path": "test/e2e/app-dir/rewrite-headers/rewrite-headers.test.ts", "patch": "@@ -315,7 +315,8 @@ const cases: {\n RSC: '1',\n },\n expected: {\n- 'x-nextjs-rewritten-path': null,\n+ // Vercel matches `/` to `/home`\n+ 'x-nextjs-rewritten-path': '/home',\n 'x-nextjs-rewr...
2025-02-03T11:17:22
golang/go
7f90b960a9711b51bf36f49be4274ac5f7e86a95
ea537cca314d9da5365eeefcc375410c76e93b36
cmd/compile: don't elide zero extension on top of signed values v = ... compute some value, which zeros top 32 bits ... w = zero-extend v We want to remove the zero-extension operation, as it doesn't do anything. But if v is typed as a signed value, and it gets spilled/restored, it might be re-sign-extended upon rest...
[ { "path": "src/cmd/compile/internal/ssa/rewrite.go", "patch": "@@ -1287,6 +1287,11 @@ func areAdjacentOffsets(off1, off2, size int64) bool {\n // depth limits recursion depth. In AMD64.rules 3 is used as limit,\n // because it catches same amount of cases as 4.\n func zeroUpper32Bits(x *Value, depth int) bo...
2024-06-28T03:45:22
nodejs/node
7ae1360358523e68e6326817815af426ea7fdc7f
e8cfa95a17cbb752af4c6f4ddc99f154021465db
src: fix typo in comment in quic/sessionticket.cc PR-URL: https://github.com/nodejs/node/pull/47754 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
[ { "path": "src/quic/sessionticket.cc", "patch": "@@ -63,7 +63,7 @@ Maybe<SessionTicket> SessionTicket::FromV8Value(Environment* env,\n !des.ReadValue(env->context()).ToLocal(&transport_params) ||\n !ticket->IsArrayBufferView() || !transport_params->IsArrayBufferView()) {\n if (tryCatch.HasCa...
2023-04-28T04:28:55
electron/electron
40aeb0d9949e3a9bfe5613f5543bb254222ca312
4f2490f8b80683dd115f851d84b123e854e32e43
fix: dont try to serialize WasmModuleObjects (#27518)
[ { "path": "shell/renderer/api/electron_api_context_bridge.cc", "patch": "@@ -96,7 +96,8 @@ bool IsPlainObject(const v8::Local<v8::Value>& object) {\n object->IsArrayBuffer() || object->IsArrayBufferView() ||\n object->IsArray() || object->IsDataView() ||\n object->IsSharedAr...
2021-01-29T02:20:28
rust-lang/rust
13c6256efe7d426abeb7c86a20b14ba38dc7ad4e
efa32de15b394620520f24781d8c55d4df6fa106
Include rustc version in ICE messages Rather than only including them in the ICE file. Not every user includes the ICE file in their bug reports, nor do they always list the rustc version.
[ { "path": "compiler/rustc_driver_impl/src/lib.rs", "patch": "@@ -1531,15 +1531,15 @@ fn report_ice(\n .map(PathBuf::from)\n .map(|env_var| session_diagnostics::IcePathErrorEnv { env_var }),\n });\n- dcx.emit_note(session_diagnost...
2025-12-24T10:21:07
facebook/react
4def1ceee2acc241f2434b2cfab6b8bc4c741cb3
af1a4cbf7adf2acae6f869e397198752d150e29a
Update DevTools Error strings to support GitHub fuzzy search (#21314)
[ { "path": "packages/react-devtools-shared/src/devtools/ProfilerStore.js", "patch": "@@ -113,7 +113,7 @@ export default class ProfilerStore extends EventEmitter<{|\n }\n \n throw Error(\n- `Could not find commit data for root \"${rootID}\" and commit ${commitIndex}`,\n+ `Could not find comm...
2021-04-19T17:05:28
golang/go
ea537cca314d9da5365eeefcc375410c76e93b36
b0927fdd494a79458ff151ce8db59963f67b80be
cmd/go/internal/help: add documentation for language version downgrading This change adds documentation for language version downgrading using build constraints. Fixes #68161 For #61894 Change-Id: I283a51afd7020c9fd1f5469a6a93fd814ba32f7e Reviewed-on: https://go-review.googlesource.com/c/go/+/595475 Reviewed-by: Rob...
[ { "path": "src/cmd/go/alldocs.go", "patch": "@@ -1994,6 +1994,9 @@\n //\n //\t//go:build\n //\n+// Build constraints can also be used to downgrade the language version\n+// used to compile a file.\n+//\n // Constraints may appear in any kind of source file (not just Go), but\n // they must appear near the t...
2024-06-27T15:16:30
vercel/next.js
bcef4dd3b46487bf359581cb223be52f39ee7003
2d4cc850a18cd2b0bae28e900105e9e1f8e673fd
fix rustflags for musl targets (#75599)
[ { "path": ".cargo/config.toml", "patch": "@@ -54,6 +54,7 @@ rustflags = [\n \n [target.aarch64-unknown-linux-musl]\n linker = \"aarch64-linux-musl-gcc\"\n+# Config need to be mirrowed to .github/workflows/build_and_deploy.yml\n rustflags = [\n \"--cfg\",\n \"tokio_unstable\",\n@@ -63,5 +64,16 @@ rustfla...
2025-02-03T10:15:42
nodejs/node
6700aac61568690ff3cc79cd6aa1d80e9ceb3c00
f34a07d3a78fe34e6221c42721ae3f2f6a3d8cf0
src: mark fatal error functions as noreturn OnFatalError and OOMErrorHandler will not return control flow to the calling function. node::FatalError is an alias of node::OnFatalError. Replace all the callsites with node::OnFatalError instead. PR-URL: https://github.com/nodejs/node/pull/47695 Reviewed-By: Tobias Nieße...
[ { "path": "src/api/environment.cc", "patch": "@@ -726,8 +726,7 @@ Maybe<bool> InitializeContextRuntime(Local<Context> context) {\n }\n } else if (per_process::cli_options->disable_proto != \"\") {\n // Validated in ProcessGlobalArgs\n- FatalError(\"InitializeContextRuntime()\",\n- ...
2023-04-27T08:57:52
electron/electron
18f4c3129d25ffb9ae0c6663f6d4eaa2d9ed4067
0bb1ba822aa109886fcf80859cf4458c45362c97
test: fix failing http spec (#27525)
[ { "path": "spec-main/extensions-spec.ts", "patch": "@@ -277,12 +277,12 @@ describe('chrome extensions', () => {\n it('can cancel http requests', async () => {\n await w.loadURL(url);\n await customSession.loadExtension(path.join(fixtures, 'extensions', 'chrome-webRequest'));\n- ...
2021-01-28T19:51:08
facebook/react
af1a4cbf7adf2acae6f869e397198752d150e29a
c3cb2c2b30b2d5e767ab57a461441d157bbb5a1e
Revert expiration for retry lanes (#21300) Retries should be allowed to expire if they are CPU bound for too long, but when I made this change it caused a spike in browser crashes. There must be some other underlying bug; not super urgent but ideally should figure out why and fix it. Unfortunately we don't have a r...
[ { "path": "packages/react-reconciler/src/ReactFiberLane.new.js", "patch": "@@ -362,12 +362,18 @@ function computeExpirationTime(lane: Lane, currentTime: number) {\n case TransitionLane14:\n case TransitionLane15:\n case TransitionLane16:\n+ return currentTime + 5000;\n case RetryLane1:\...
2021-04-16T21:45:09
golang/go
a2e90be996fb0e75966b1e1097dd20aa07eebc37
90bcc552c0347948166817a602f612f219bc980c
os: rewrite TestChtimesWithZeroTimes First, this enables checks on DragonFly BSD, which partially works since CL 589496 (except two things: atime is not supported on hammer2 fs, and when both times are omitted, it doesn't work due to a kernel bug). Second, there are a few problems with TestChtimesWithZeroTimes: - t...
[ { "path": "src/os/os_test.go", "patch": "@@ -1383,123 +1383,108 @@ func TestChtimes(t *testing.T) {\n \ttestChtimes(t, f.Name())\n }\n \n-func TestChtimesWithZeroTimes(t *testing.T) {\n+func TestChtimesOmit(t *testing.T) {\n+\tt.Parallel()\n+\n+\ttestChtimesOmit(t, true, false)\n+\ttestChtimesOmit(t, false,...
2024-06-09T19:47:23
vercel/next.js
cefa93ca5cc2f2fb82ace84d02928f0d3b30430f
58e1bd29a1563032244ee6d3ca689eb255756e0d
Fix corepack keys (#75600)
[ { "path": ".devcontainer/Dockerfile", "patch": "@@ -28,4 +28,5 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \\\n # RUN su node -c \"npm install -g <your-package-list-here>\"\n \n # Enable pnpm\n+RUN npm i -g corepack@latest\n RUN corepack enable pnpm\n\\ No newline at end of file", "ad...
2025-02-03T09:57:22
nodejs/node
f34a07d3a78fe34e6221c42721ae3f2f6a3d8cf0
b6738c1af040505bcb241b8740eb91e81c15eb44
stream: prevent pipeline hang with generator functions Fixes: https://github.com/nodejs/node/issues/47708 PR-URL: https://github.com/nodejs/node/pull/47712 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
[ { "path": "lib/internal/streams/pipeline.js", "patch": "@@ -138,10 +138,9 @@ async function pumpToNode(iterable, writable, finish, { end }) {\n \n if (end) {\n writable.end();\n+ await wait();\n }\n \n- await wait();\n-\n finish();\n } catch (err) {\n finish(error !== err ? a...
2023-04-27T07:44:39
electron/electron
bf6a50c53821ba71625459ebd502e261bbcd9773
e94f97f2c9867ca7d9f47e5bf088adbe4dd7c8e7
fix: pdf viewer missing resources (#27499) * fix: pdf viewer missing resources * test: add simple regression test * 2638992: PDF Viewer: Stop respecting the PDFViewerUpdate flag. https://chromium-review.googlesource.com/c/chromium/src/+/2638992 * 2439433: PDF Viewer Update: Add aria-label for thumbnails ...
[ { "path": "BUILD.gn", "patch": "@@ -648,6 +648,7 @@ source_set(\"electron_lib\") {\n }\n if (enable_pdf_viewer) {\n deps += [\n+ \"//chrome/browser/resources/pdf:pdf_resources\",\n \"//components/pdf/browser\",\n \"//components/pdf/renderer\",\n \"//pdf:pdf_ppapi\",", "add...
2021-01-28T01:09:55
facebook/react
c3cb2c2b30b2d5e767ab57a461441d157bbb5a1e
d14b6a4bddda99421df7ed53ae6a7c682c4b50a9
Fix DevTools test target (#21267)
[ { "path": "scripts/jest/jest-cli.js", "patch": "@@ -104,8 +104,9 @@ function logError(message) {\n }\n function isWWWConfig() {\n return (\n- argv.releaseChannel === 'www-classic' ||\n- argv.releaseChannel === 'www-modern'\n+ (argv.releaseChannel === 'www-classic' ||\n+ argv.releaseChannel =...
2021-04-16T20:19:05
golang/go
90bcc552c0347948166817a602f612f219bc980c
b1fd047508aad9f5038dc04d78146cc582328bf5
crypto/tls: apply QUIC session event flag to QUICResumeSession events Go 1.23 adds two new events to QUICConns: QUICStoreSessionEvent and QUICResumeSessionEvent. We added a QUICConfig.EnableStoreSessionEvent flag to control whether the store-session event is provided or not, because receiving this event requires addit...
[ { "path": "api/go1.23.txt", "patch": "@@ -18,7 +18,7 @@ pkg crypto/tls, type Config struct, EncryptedClientHelloRejectionVerify func(Con\n pkg crypto/tls, type ConnectionState struct, ECHAccepted bool #63369\n pkg crypto/tls, type ECHRejectionError struct #63369\n pkg crypto/tls, type ECHRejectionError stru...
2024-06-24T17:01:47
vercel/next.js
0f7251fc78db5c774f82285bcd1eed8e73564bb7
28ac62893809456b82541e74ee4786d7ea4e13f6
fix(dev-server): Terminate turbopack HMR websocket connections during exit (#75344) Without this change, an open browser tab with an HMR websocket subscription (which is very common) can prevent next.js's dev server from exiting cleanly (falls back to a SIGKILL after a 100ms timeout). That's bad (aside from the extra...
[ { "path": "packages/next/src/server/dev/hot-middleware.ts", "patch": "@@ -72,16 +72,11 @@ class EventStream {\n this.clients = new Set()\n }\n \n- everyClient(fn: (client: ws) => void) {\n- for (const client of this.clients) {\n- fn(client)\n- }\n- }\n-\n close() {\n- this.everyClien...
2025-01-30T16:48:50
nodejs/node
ece356589383aa110b69b555ce74dc17f1fa5fd6
e2e3f5c9daeca9a01f1ac07b7ea627748d7feeca
doc: fix a typo in `permissions.md` Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/47730 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <...
[ { "path": "doc/api/permissions.md", "patch": "@@ -536,7 +536,7 @@ Example:\n \n Wildcards are supported too:\n \n-* `--allow-fs-read:/home/test*` will allow read access to everything\n+* `--allow-fs-read=/home/test*` will allow read access to everything\n that matches the wildcard. e.g: `/home/test/file1`...
2023-04-26T18:34:52
facebook/react
5027eb4650730d2bc7f909f2567828ffdf938642
c1a53ad2b2f29f30412c682b42bdd6ac3227eafa
DevTools fork console patching logic (#21301) React has its own component stack generation code that DevTools embeds a fork of, but both of them use a shared helper for disabling console logs. This shared helper is DEV only though, because it was intended for use with React DEV-only warnings and we didn't want to unne...
[ { "path": "packages/react-devtools-core/webpack.backend.js", "patch": "@@ -58,6 +58,9 @@ module.exports = {\n 'process.env.GITHUB_URL': `\"${GITHUB_URL}\"`,\n }),\n ],\n+ optimization: {\n+ minimize: false,\n+ },\n module: {\n rules: [\n {", "additions": 3, "deletions": ...
2021-04-16T16:01:47
golang/go
b1fd047508aad9f5038dc04d78146cc582328bf5
b3b4556c245c8f21872910ee866133428bbb5a60
cmd/internal/obj/arm64: fix return with register ARM64 allows for a register to be specified with a return instruction. While the assembler parsing and encoding currently supports this, the preprocess function uses LR unconditionally. Correct this such that if a register is specified, the register is used. Change-Id:...
[ { "path": "src/cmd/asm/internal/asm/testdata/arm64.s", "patch": "@@ -961,7 +961,11 @@ again:\n \tCASPD\t(R2, R3), (R2), (R8, R9) // 487c2248\n \n // RET\n-\tRET\n+\tRET // c0035fd6\n+\tRET R0\t\t\t\t\t // 00005fd6\n+\tRET R6\t\t\t\t\t // c0005fd6\n+\tRE...
2024-06-14T15:28:46
vercel/next.js
28ac62893809456b82541e74ee4786d7ea4e13f6
82026906a66e7a51b35d142497bc6db55771ac51
Reapply "fix: handle optional catchalls correctly" (#75442) (#75450) This is a reapplication of the [original fix](https://github.com/vercel/next.js/pull/75377) for optional catchall routes but narrowed to only when the parameters weren't already valid.
[ { "path": "packages/next/src/server/base-server.ts", "patch": "@@ -1182,7 +1182,8 @@ export default abstract class Server<\n let params: ParsedUrlQuery | false = {}\n \n let paramsResult = utils.normalizeDynamicRouteParams(\n- parsedUrl.query\n+ parsedUrl.qu...
2025-01-30T15:43:54
nodejs/node
ad5a0d1366a2c019c62e21ac35f62820ed342f31
76044c4e2b6ac6f7d7ca02edfdf9f6e475b4edb3
tools: fix update-v8-patch cache PR-URL: https://github.com/nodejs/node/pull/47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
[ { "path": ".github/workflows/update-v8.yml", "patch": "@@ -19,12 +19,16 @@ jobs:\n - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0\n with:\n persist-credentials: false\n- - uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3.3.1\n+ ...
2023-04-26T13:43:16
facebook/react
f3337aa544998be249c63ad3accc5008dbb938ed
9eddfbf5af13d95c703c10072c8c2f7c0ddf8071
DevTools error boundary: Search for pre-existing GH issues (#21279)
[ { "path": "packages/react-devtools-shared/package.json", "patch": "@@ -8,6 +8,7 @@\n },\n \"dependencies\": {\n \"@babel/runtime\": \"^7.11.2\",\n+ \"@octokit/rest\": \"^18.5.2\",\n \"@reach/menu-button\": \"^0.1.17\",\n \"@reach/tooltip\": \"^0.2.2\",\n \"clipboard-js\": \"^0.3.6\","...
2021-04-15T17:34:54
golang/go
29b1a6765fb5f124171d94f157b6d6c3b2687468
cf54a3d11469e3e9bd531ee2cdeaf613467923f1
net/http: document that Request.Clone does not deep copy Body Fixes #36095 Change-Id: I94ae014b0ee45b4aeb38cb247e42cfc13f663ded Reviewed-on: https://go-review.googlesource.com/c/go/+/593175 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@g...
[ { "path": "src/net/http/request.go", "patch": "@@ -377,6 +377,8 @@ func (r *Request) WithContext(ctx context.Context) *Request {\n // Clone returns a deep copy of r with its context changed to ctx.\n // The provided ctx must be non-nil.\n //\n+// Clone only makes a shallow copy of the Body field.\n+//\n // ...
2024-06-17T21:54:22
vercel/next.js
c5441e30ded964541f5ab156acd10a8fe0098b4d
9a6b0f517cb67e94d25ddadd53fecbf649d3b830
[Turbopack] fix unsafe pinning code (#75473) ### What? Not sure exactly why, but the previous code caused hanging on event listeners...
[ { "path": "turbopack/crates/turbo-tasks/src/event.rs", "patch": "@@ -10,7 +10,6 @@ use std::{\n fmt::{Debug, Formatter},\n future::Future,\n mem::replace,\n- pin::Pin,\n };\n \n #[cfg(feature = \"hanging_detection\")]\n@@ -144,7 +143,8 @@ impl Future for EventListener {\n self: std::p...
2025-01-30T10:28:57
nodejs/node
2ac5e9889aba461f5a54d320973d2574980d206b
71a776b9283dea5aff42b52997389e5a1a4b5455
dns: expose getDefaultResultOrder PR-URL: https://github.com/nodejs/node/pull/46973 Fixes: https://github.com/nodejs/node/issues/46919 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
[ { "path": "doc/api/dns.md", "patch": "@@ -792,6 +792,18 @@ priority than [`--dns-result-order`][]. When using [worker threads][],\n [`dns.setDefaultResultOrder()`][] from the main thread won't affect the default\n dns orders in workers.\n \n+## `dns.getDefaultResultOrder()`\n+\n+<!-- YAML\n+added: REPLACEME...
2023-04-26T08:56:04
facebook/react
9eddfbf5af13d95c703c10072c8c2f7c0ddf8071
11b07597ee96305283449e9eae6d12fb6077a9c6
[Fizz] Two More Fixes (#21288) * Emit value of option tags * Mask the legacy context passed to classes
[ { "path": "packages/react-dom/src/server/ReactDOMServerFormatConfig.js", "patch": "@@ -729,15 +729,16 @@ function pushStartOption(\n }\n }\n break;\n- case 'value':\n- value = propValue;\n- break;\n case 'dangerouslySetInnerHTML':\n ...
2021-04-15T17:26:49
electron/electron
1023988ea86c13e069011f8b3b4f99c28d47bf9c
e7c201288c3d29803f7885aad8373f7ebc540256
build: fix build with enable_printing=false (#27456)
[ { "path": "shell/browser/api/electron_api_web_contents.cc", "patch": "@@ -618,7 +618,9 @@ WebContents::WebContents(v8::Isolate* isolate,\n devtools_file_system_indexer_(new DevToolsFileSystemIndexer),\n file_task_runner_(\n base::ThreadPool::CreateSequencedTaskRunner({base::MayBlock()}...
2021-01-25T16:27:25
vercel/next.js
8db39d6c00351be425c0d45a0c806df0efd2b9ab
9fc4d39aba24eb5740542f74aadcc4d3a286c6c2
fix: `client-only` error message format (#75446) Looking at the test file change should convince you that this fixes the formatting issue. https://linear.app/vercel/issue/NDX-671/error-from-client-only-package-is-malformed
[ { "path": "crates/next-custom-transforms/src/transforms/react_server_components.rs", "patch": "@@ -277,8 +277,8 @@ fn report_error(app_dir: &Option<PathBuf>, filepath: &str, error_kind: RSCErrorK\n // If importing \"react-dom/server\", we should show a different error.\n \"re...
2025-01-30T00:33:59
nodejs/node
b54504c1d53796e02967e2c6c0a48416e64cf4e1
11f97d4603c5f51d091ca730411251be21bd30ce
tls: accept SecureContext object in server.addContext() Do not call tls.createSecureContext() if the context provided is already an instance of tls.SecureContext. Fixes: https://github.com/nodejs/node/issues/47408 PR-URL: https://github.com/nodejs/node/pull/47570 Reviewed-By: Anna Henningsen <anna@addaleax.net> Revie...
[ { "path": "doc/api/tls.md", "patch": "@@ -728,9 +728,10 @@ added: v0.5.3\n -->\n \n * `hostname` {string} A SNI host name or wildcard (e.g. `'*'`)\n-* `context` {Object} An object containing any of the possible properties\n- from the [`tls.createSecureContext()`][] `options` arguments (e.g. `key`,\n- `cer...
2023-04-26T06:39:00
facebook/react
11b07597ee96305283449e9eae6d12fb6077a9c6
96d00b9bba82d9b9f94a4986e52c38b995ef9941
Fix classes (#21283)
[ { "path": "packages/react-server/src/ReactFizzClassComponent.js", "patch": "@@ -609,7 +609,7 @@ export function mountClassInstance(\n \n // The internal instance will be used to manage updates that happen during this mount.\n const internalInstance: InternalInstance = {\n- queue: null,\n+ queue: [...
2021-04-15T15:06:31
electron/electron
64b7be751a92076f0f00eac02d79feb87e80a125
4a5c5843c49938edcde156eff5d3bf9fdb5d1455
fix: CSP with `unsafe-eval` detection with Trusted Types (#27446)
[ { "path": "lib/renderer/security-warnings.ts", "patch": "@@ -81,7 +81,7 @@ const isUnsafeEvalEnabled: () => Promise<boolean> = function () {\n // Call _executeJavaScript to bypass the world-safe deprecation warning\n return (webFrame as any)._executeJavaScript(`(${(() => {\n try {\n- new Functi...
2021-01-25T01:31:25
nodejs/node
146b613941853aaa013d35d6a45724569ce29879
a437bb9e6d495262e99a09ef1ba5d6aaf1ba9799
src: prevent changing FunctionTemplateInfo after publish Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147 Fixes an issue where Node.js tries to call SetClassName on a FunctionTemplate twice in some cases. The above CL made it so that V8 CHECKs when this occurs. It is fixed by ensuring SetClassName is o...
[ { "path": "src/histogram.cc", "patch": "@@ -345,7 +345,8 @@ void HistogramBase::Initialize(IsolateData* isolate_data,\n SetConstructorFunction(isolate_data->isolate(),\n target,\n \"Histogram\",\n- GetConstructorTemplate(isolate_dat...
2023-04-25T09:12:45
facebook/react
96d00b9bba82d9b9f94a4986e52c38b995ef9941
0e100ed00fb52cfd107db1d1081ef18fe4b9167f
[Fizz] Random Fixes (#21277)
[ { "path": "packages/react-dom/src/__tests__/ReactDOMFizzServerBrowser-test.js", "patch": "@@ -56,7 +56,7 @@ describe('ReactDOMFizzServer', () => {\n );\n const result = await readResult(stream);\n expect(result).toMatchInlineSnapshot(\n- `\"<div data-reactroot=\\\\\"\\\\\">hello world<!-- -...
2021-04-15T03:29:30
vercel/next.js
8ed8716c09a23a70e61bbb09ee9cfc567c64db50
5f47bb15979b52a16fd9141cbb20d16fe0910003
perf(turbo-tasks): Filter out and do not cache unused arguments (#75261) For trait methods, we often have underscore-prefixed arguments that are unused in method implementations, but must exist on the method signature because the trait requires it. For example, look at `code_generation`: https://github.com/search?q=r...
[ { "path": "turbopack/crates/turbo-tasks-macros/src/func.rs", "patch": "@@ -27,7 +27,7 @@ pub struct TurboFn<'a> {\n \n output: Type,\n this: Option<Input>,\n- inputs: Vec<Input>,\n+ exposed_inputs: Vec<Input>,\n /// Should we return `OperationVc` and require that all arguments are `NonLoca...
2025-01-29T21:51:46
golang/go
cf54a3d11469e3e9bd531ee2cdeaf613467923f1
b98803e8e5e4e3077207d5c473f1938dfd9dcff2
crypto/tls: replay test recordings without network There is no reason to go across a pipe when replaying a conn recording. This avoids the complexity of using localPipe and goroutines, and makes handshake benchmarks more accurate, as we don't measure network overhead. Also note how it removes the need for -fast: oper...
[ { "path": "src/crypto/tls/handshake_client_test.go", "patch": "@@ -283,7 +283,7 @@ func (test *clientTest) loadData() (flows [][]byte, err error) {\n }\n \n func (test *clientTest) run(t *testing.T, write bool) {\n-\tvar clientConn, serverConn net.Conn\n+\tvar clientConn net.Conn\n \tvar recordingConn *reco...
2024-06-23T12:10:14
rust-lang/rust
5fbb39c036c8620d2d8efa54b6e1bfc5bd664008
7076d693ed794bd89f9539987635304ed5f1d5e1
Fix function formatting in src/overview.md
[ { "path": "src/doc/rustc-dev-guide/src/overview.md", "patch": "@@ -50,10 +50,10 @@ preserves full fidelity information for both IDEs and procedural macros\n The *parser* [translates the token stream from the `lexer` into an Abstract Syntax\n Tree (AST)][parser]. It uses a recursive descent (top-down) approa...
2025-12-23T06:22:59
electron/electron
4a5c5843c49938edcde156eff5d3bf9fdb5d1455
949fd0728fb56d06c33982a5523c5952511606e9
fix: <webview> not working with Trusted Types (#27445)
[ { "path": "lib/renderer/web-view/web-view-impl.ts", "patch": "@@ -44,7 +44,9 @@ export class WebViewImpl {\n // Create internal iframe element.\n this.internalElement = this.createInternalElement();\n const shadowRoot = this.webviewNode.attachShadow({ mode: 'open' });\n- shadowRoot.innerHTML ...
2021-01-25T01:29:25
nodejs/node
dccd25e5bb524d56bc8ad7f703204a9852f574a4
dac02632a6394458727cf448178d96c2636f4455
test_runner: fix test runner concurrency PR-URL: https://github.com/nodejs/node/pull/47675 Fixes: https://github.com/nodejs/node/issues/47365 Fixes: https://github.com/nodejs/node/issues/47696 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Col...
[ { "path": "lib/internal/per_context/primordials.js", "patch": "@@ -565,13 +565,7 @@ primordials.SafePromiseAllSettled = (promises, mapFn) =>\n * @returns {Promise<void>}\n */\n primordials.SafePromiseAllSettledReturnVoid = async (promises, mapFn) => {\n- for (let i = 0; i < promises.length; i++) {\n- ...
2023-04-22T20:32:12
facebook/react
0e100ed00fb52cfd107db1d1081ef18fe4b9167f
81ef5395358b6e0f44a02df618901eaef830fe78
Gate a test (#21275) Rebase error
[ { "path": "packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js", "patch": "@@ -800,6 +800,7 @@ describe('ReactDOMFizzServer', () => {\n );\n });\n \n+ // @gate experimental\n it('client renders a boundary if it errors before finishing the fallback', async () => {\n function App({isClien...
2021-04-14T23:37:44
golang/go
b98803e8e5e4e3077207d5c473f1938dfd9dcff2
0def9d5c02166b50a011b4cc8d4c1d891a04f89d
os: TestChtimes: separate hasNoatime Move the noatime check to a separate function (to be used by CL 91535), adding some documentation along the way. Unify the atime error message. Change-Id: I5f75a4399f6e1b16ae20438003de5460f3eeb5aa Reviewed-on: https://go-review.googlesource.com/c/go/+/594075 Reviewed-by: Ian Lanc...
[ { "path": "src/os/os_test.go", "patch": "@@ -1361,6 +1361,17 @@ func TestTruncateNonexistentFile(t *testing.T) {\n \tassertPathError(t, path, err)\n }\n \n+var hasNoatime = sync.OnceValue(func() bool {\n+\t// A sloppy way to check if noatime flag is set (as all filesystems are\n+\t// checked, not just the o...
2024-06-21T23:59:21
vercel/next.js
8514cd64b1b1934483b5ecdb65fbec6a400dc47a
c0d23aee2f7cd1947e362cb18d18243435a3eed6
Revert "fix: handle optional catchalls correctly" (#75442) We noticed a routing regression, so reverting while we investigate. Reverts vercel/next.js#75377
[ { "path": "packages/next/src/server/base-server.ts", "patch": "@@ -1237,13 +1237,16 @@ export default abstract class Server<\n typeof routeMatchesHeader === 'string' &&\n routeMatchesHeader &&\n isDynamicRoute(matchedPath) &&\n- (Object.keys(params).len...
2025-01-29T19:14:53
facebook/react
a4a940d7a15814e50c977179f7d2be3c76611707
f4d7a0f1ea0cd24e1979a9be6b2778b98cef414c
[Fizz] Add unsupported Portal/Scope components (#21261) * Update Portal error message * Add Scope Component
[ { "path": "packages/react-server/src/ReactFizzServer.js", "patch": "@@ -94,12 +94,14 @@ import {\n REACT_MEMO_TYPE,\n REACT_PROVIDER_TYPE,\n REACT_CONTEXT_TYPE,\n+ REACT_SCOPE_TYPE,\n } from 'shared/ReactSymbols';\n import ReactSharedInternals from 'shared/ReactSharedInternals';\n import {\n disabl...
2021-04-14T21:35:36
electron/electron
5a8f40ae13f5c2872bef6e6a0deee41c50acf9cf
d69e0d05731a7ef474ead8b0d710c184f5e346cd
fix: don't throw on bad icons in BrowserWindow constructor (#27441) * fix: do not throw if NativeImage conversion fails. Throwing is an unannounced semver/major breaking change, so revert that behavior but keep the rest of the #26546 refactor. * test: add invalid icon test * refactor: be explicit about when ...
[ { "path": "shell/browser/api/electron_api_base_window.cc", "patch": "@@ -101,7 +101,7 @@ BaseWindow::BaseWindow(v8::Isolate* isolate,\n #if defined(TOOLKIT_VIEWS)\n v8::Local<v8::Value> icon;\n if (options.Get(options::kIcon, &icon)) {\n- SetIcon(isolate, icon);\n+ SetIconImpl(isolate, icon, Nativ...
2021-01-25T01:24:10
nodejs/node
dac02632a6394458727cf448178d96c2636f4455
8becacb25d3c275341a9fef1a94581de3bd60c3d
test_runner: fix test counting PR-URL: https://github.com/nodejs/node/pull/47675 Fixes: https://github.com/nodejs/node/issues/47365 Fixes: https://github.com/nodejs/node/issues/47696 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <...
[ { "path": "lib/internal/test_runner/harness.js", "patch": "@@ -176,7 +176,7 @@ function setup(root) {\n cancelled: 0,\n skipped: 0,\n todo: 0,\n- planned: 0,\n+ topLevel: 0,\n suites: 0,\n },\n };", "additions": 1, "deletions": 1, "language": "JavaScript" ...
2023-04-24T12:04:59
golang/go
e8ee1dc4f9e2632ba1018610d1a1187743ae397f
44f18706661db8b865719d15a5cfa0515d1a4fca
cmd/link/internal/ld: handle "\r" in MinGW "--print-prog-name" output Fix the "gcc --print-prog-name" output parser to handle "\r\n", not only "\n". The MinGW compiler on Windows uses "\r\n" as line endings, causing the existing parser to create paths like ".../x86_64-w64-mingw32/bin/ar.exe\r", which is not correct. B...
[ { "path": "src/cmd/link/internal/ld/lib.go", "patch": "@@ -2917,6 +2917,6 @@ func (ctxt *Link) findExtLinkTool(toolname string) string {\n \tif err != nil {\n \t\tExitf(\"%s: finding %s failed: %v\\n%s\", os.Args[0], toolname, err, out)\n \t}\n-\tcmdpath := strings.TrimSuffix(string(out), \"\\n\")\n+\tcmdpa...
2024-06-21T23:44:44
rust-lang/rust
6bc65090756d6d81d3414fdc50f856ea45a24046
01b39655df52597ddf31c0e243d3bfbdbf3a0be0
fix: `manual_is_multiple_of` wrongly unmangled macros
[ { "path": "clippy_lints/src/operators/manual_is_multiple_of.rs", "patch": "@@ -35,7 +35,7 @@ pub(super) fn check<'tcx>(\n {\n let mut app = Applicability::MachineApplicable;\n let divisor = deref_sugg(\n- Sugg::hir_with_applicability(cx, operand_right, \"_\", &mut app),\n+ ...
2025-12-24T00:21:23
vercel/next.js
5aa6d9e82a10395583650c3131bdefb524f6c3a8
0be280dc79a25425d496cff4139029aef711c304
[Turbopack] fix is_empty implementation (#75426) ### What? The AggregationQueue has multiple queues that need to be checked for emptyness.
[ { "path": "turbopack/crates/turbo-tasks-backend/src/backend/operation/aggregation_update.rs", "patch": "@@ -589,7 +589,20 @@ impl AggregationUpdateQueue {\n \n /// Returns true, when the queue is empty.\n pub fn is_empty(&self) -> bool {\n- self.jobs.is_empty()\n+ let Self {\n+ ...
2025-01-29T17:05:46
electron/electron
d69e0d05731a7ef474ead8b0d710c184f5e346cd
9baca911a1d00a37a4b04415746b2b4e5525ba08
fix: hiddenInset missing maximize button (#27428)
[ { "path": "shell/browser/native_window_mac.mm", "patch": "@@ -1764,12 +1764,12 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {\n [[window_ standardWindowButton:NSWindowZoomButton] setHidden:YES];\n [[window_ standardWindowButton:NSWindowMiniaturizeButton] setHidden:YES];\n [[windo...
2021-01-25T00:59:06
nodejs/node
8becacb25d3c275341a9fef1a94581de3bd60c3d
a51c894937ed7f5b6a886e0570468f2055cbf991
tools: fix skip message in update-cjs-module-lexer Refs: https://github.com/nodejs/node/pull/47446 PR-URL: https://github.com/nodejs/node/pull/47701 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By:...
[ { "path": "tools/dep_updaters/update-cjs-module-lexer.sh", "patch": "@@ -24,7 +24,7 @@ CURRENT_VERSION=$(\"$NODE\" -p \"require('./deps/cjs-module-lexer/package.json').ve\n echo \"Comparing $NEW_VERSION with $CURRENT_VERSION\"\n \n if [ \"$NEW_VERSION\" = \"$CURRENT_VERSION\" ]; then\n- echo \"Skipped beca...
2023-04-24T17:34:01
rust-lang/rust
21eaa04df821f0c716a9cbca2e502aef50e4d2e3
b946ba1ad3f0f9e532bb987b5758db762b644c4b
fix: `needless_for_each` FN when `for_each` is in the expr of a block
[ { "path": "clippy_lints/src/needless_for_each.rs", "patch": "@@ -56,8 +56,20 @@ declare_lint_pass!(NeedlessForEach => [NEEDLESS_FOR_EACH]);\n \n impl<'tcx> LateLintPass<'tcx> for NeedlessForEach {\n fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx Stmt<'_>) {\n- if let StmtKind::Expr(...
2025-12-24T00:09:43
golang/go
44f18706661db8b865719d15a5cfa0515d1a4fca
0af2148fdcd047e5aa15776a54ccc29d9aa36f7f
cmd/link: handle dynamic import variables on Darwin in plugin mode CL 501855 added support for cgo_dynamic_import variables on Darwin. But it didn't support the plugin build mode on amd64, where the assembler turns a direct load (R_PCREL) to a load via GOT (R_GOTPCREL). This CL adds the support. We just need to handle...
[ { "path": "src/cmd/cgo/internal/testplugin/plugin_test.go", "patch": "@@ -414,3 +414,11 @@ func TestTextSectionSplit(t *testing.T) {\n \t\tt.Errorf(\"runtime.text.1 not found, text section not split?\")\n \t}\n }\n+\n+func TestIssue67976(t *testing.T) {\n+\t// Issue 67976: build failure with loading a dynim...
2024-06-17T18:44:42
vercel/next.js
0be280dc79a25425d496cff4139029aef711c304
348c7fe30ecc8731c6f34645aca409bb8d7b9da2
Revert changing bundler for runtime bundle but keep externals fix (#75412) This reverts the bundler change part while we investigate source map issue but keeps the externals optimize preventing the runtime bundle from inflating back to over `4MB`. This reverts commit 98b0700e9746387ce63ac715d300be82100dce55 This...
[ { "path": ".eslintrc.json", "patch": "@@ -162,7 +162,7 @@\n \"files\": [\"packages/**\"],\n \"excludedFiles\": [\n \"packages/next/taskfile*.js\",\n- \"packages/next/next_runtime.config.js\"\n+ \"packages/next/next-runtime.webpack-config.js\"\n ],\n \"rules\": {...
2025-01-29T16:50:31
electron/electron
4f930b6e42967d4d72930b1aa9457d0f30b95ed5
96e8620e1bdcf3de88206c7b24c8f1f8bb45d7a6
fix: add eyedropper tool functionality to browser view (#27275)
[ { "path": "chromium_src/BUILD.gn", "patch": "@@ -145,10 +145,17 @@ static_library(\"chrome\") {\n \"//chrome/browser/platform_util.h\",\n \"//chrome/browser/ui/browser_dialogs.h\",\n \"//chrome/browser/ui/color_chooser.h\",\n+ \"//chrome/browser/ui/views/eye_dropper/eye_dropper.cc\",\...
2021-01-21T21:02:29
nodejs/node
3e7459055bbcfe35e203896cb9afffa10db2f256
2fbe124e68c040904e990c23083a63e163a3085d
doc: fix a typo in `fs.openAsBlob` Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/47693 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
[ { "path": "doc/api/fs.md", "patch": "@@ -3383,10 +3383,9 @@ added: v19.8.0\n Returns a {Blob} whose data is backed by the given file.\n \n The file must not be modified after the {Blob} is created. Any modifications\n-will cause reading the {Blob} data to fail with a `DOMException`.\n-error. Synchronous sta...
2023-04-24T07:36:53
golang/go
fed2c11d67dbe6d8179cd411b4bb7761d034e9d2
d73a8a206a7d3c179cdc498a29be215fa48a1ec2
iter: minor doc comment updates Remove old return value. Use single variable range for iter.Seq[V]. Rewrite Pairs implementation to not loop forever. Fixes #68056 Fixes #68073 Change-Id: I7ede0fe8ed058bbd57869d87e17b7f2c3641f7dd Reviewed-on: https://go-review.googlesource.com/c/go/+/593555 LUCI-TryBot-Result: Go LUC...
[ { "path": "src/iter/iter.go", "patch": "@@ -31,7 +31,7 @@ element in the sequence, false if it should stop.\n Iterator functions are most often called by a range loop, as in:\n \n \tfunc PrintAll[V any](seq iter.Seq[V]) {\n-\t\tfor _, v := range seq {\n+\t\tfor v := range seq {\n \t\t\tfmt.Println(v)\n \t\t...
2024-06-19T00:49:10
facebook/react
a597c2f5dc5596bea331b455aca0548fb933038e
68097787f6e8f6d73af06e7c549a294df942b986
[Fizz] Fix reentrancy bug (#21270) * Fix reentrancy bug * Fix another reentrancy bug There's also an issue if we try to schedule something to be client rendered if its fallback hasn't rendered yet. So we don't do it in that case.
[ { "path": "packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js", "patch": "@@ -353,13 +353,16 @@ describe('ReactDOMFizzServer', () => {\n \n await act(async () => {\n const {startWriting} = ReactDOMFizzServer.pipeToNodeWritable(\n- <Suspense fallback={<Text text=\"Loading A...\" />}...
2021-04-14T20:49:14
vercel/next.js
348c7fe30ecc8731c6f34645aca409bb8d7b9da2
38efbed5b17e93e6f6bd2ac7a4497780e2cfdd51
Add temporary CI workflows for testing (#75432) ## What? Temporary CI workflows for #74554. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the c...
[ { "path": ".github/workflows/rspack-nextjs-build-integration-tests.yml", "patch": "@@ -0,0 +1,211 @@\n+# Reusable workflow to execute certain version of Next.js integration tests\n+# with Rspack.\n+#\n+# Refer test.yml for how this workflow is being initialized\n+# - Workflow can specify `inputs.version` to...
2025-01-29T15:55:14
electron/electron
949cfea1e9922d4a2248f82be0a01d6a530baaf4
c8696d2c3d3b6dee94a134f8ba35f74280d06f7d
fix: actually clear pending requests in devtoolsagenthost (#27379)
[ { "path": "shell/browser/api/electron_api_debugger.cc", "patch": "@@ -185,6 +185,7 @@ v8::Local<v8::Promise> Debugger::SendCommand(gin::Arguments* args) {\n void Debugger::ClearPendingRequests() {\n for (auto& it : pending_requests_)\n it.second.RejectWithErrorMessage(\"target closed while handling co...
2021-01-21T19:00:43
nodejs/node
2fbe124e68c040904e990c23083a63e163a3085d
3e9ed7e95fff075e839035cc12d92fea2f1a9744
http: add highWaterMark opt in http.createServer Add highWaterMark option when creating a new HTTP server. This option will override the default (readable|writable) highWaterMark values on sockets created. Fixes: https://github.com/nodejs/node/issues/46606 PR-URL: https://github.com/nodejs/node/pull/47405 Reviewed-By...
[ { "path": "doc/api/http.md", "patch": "@@ -3192,6 +3192,9 @@ Found'`.\n <!-- YAML\n added: v0.1.13\n changes:\n+ - version: REPLACEME\n+ pr-url: https://github.com/nodejs/node/pull/47405\n+ description: The `highWaterMark` option is supported now.\n - version: v18.0.0\n pr-url: https://github.c...
2023-04-24T05:35:38
facebook/react
4f76a28c93c56e3f0c03150460fd4236880e0c94
6b3d86a2e92fdb79dedf05b759860bd7fd911222
[Fizz] Implement New Context (#21255) * Add NewContext module This implements a reverse linked list tree containing the previous contexts. * Implement recursive algorithm This algorithm pops the contexts back to a shared ancestor on the way down the stack and then pushes new contexts in reverse order up the...
[ { "path": "packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js", "patch": "@@ -727,4 +727,70 @@ describe('ReactDOMFizzServer', () => {\n </div>,\n );\n });\n+\n+ // @gate experimental\n+ it('should resume the context from where it left off', async () => {\n+ const ContextA = React.c...
2021-04-14T18:45:42
golang/go
d73a8a206a7d3c179cdc498a29be215fa48a1ec2
1b4f1dc95d221c1e9d0afb9067fd6a09f12dd061
cmd/cgo: fail on v, err := C.fn when fn is a builtin function We were already checking for _CMalloc, but in fact none of the builtin functions support returning an error. Fixes #67707 Change-Id: I0ee432a9f13ace472c3f36f641efc7d18eda0631 Reviewed-on: https://go-review.googlesource.com/c/go/+/589575 Auto-Submit: Ian L...
[ { "path": "src/cmd/cgo/gcc.go", "patch": "@@ -1601,8 +1601,8 @@ func (p *Package) rewriteName(f *File, r *Ref, addPosition bool) ast.Expr {\n \t\t\tbreak\n \t\t}\n \t\tif r.Context == ctxCall2 {\n-\t\t\tif r.Name.Go == \"_CMalloc\" {\n-\t\t\t\terror_(r.Pos(), \"no two-result form for C.malloc\")\n+\t\t\tif ...
2024-05-31T05:29:35
vercel/next.js
65d1943ac09ecb2d023921a2351652ce025447a7
6c3218a3cf6be33f238d23e426144d75064fdad9
Turbopack: Use from_utf8_unchecked for minify output (#75422) ## What? Matches other places where codegen happens. In benchmarks this is a roughly 100 microseconds win per file processed through minifying. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as s...
[ { "path": "turbopack/crates/turbopack-ecmascript/src/minify.rs", "patch": "@@ -100,7 +100,7 @@ pub async fn minify(\n &ExtraOptions {\n top_level_mark,\n unresolved_mark,\n- mangle_name_cache: Default:...
2025-01-29T12:39:36
electron/electron
c5a41defbd940eb2d793f2bc438f34d1be0a628b
8b74361b0cd21883ad21a5029ef6d97a2debe95e
fix: enable navigator.setAppBadge/clearAppBadge (#27067)
[ { "path": "docs/api/app.md", "patch": "@@ -1174,9 +1174,9 @@ For `infoType` equal to `basic`:\n \n Using `basic` should be preferred if only basic information like `vendorId` or `driverId` is needed.\n \n-### `app.setBadgeCount(count)` _Linux_ _macOS_\n+### `app.setBadgeCount([count])` _Linux_ _macOS_\n \n-...
2021-01-21T05:45:06
nodejs/node
95e40b528d1c21b37518f2b0e7d297606435ef45
32e478d7c37a0296b2bf616ee2e39e81e4c8d694
test_runner: fix nested hooks PR-URL: https://github.com/nodejs/node/pull/47648 Fixes: https://github.com/nodejs/node/issues/47643 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
[ { "path": "lib/internal/test_runner/test.js", "patch": "@@ -192,6 +192,13 @@ class Test extends AsyncResource {\n this.testNumber = 0;\n this.timeout = kDefaultTimeout;\n this.root = this;\n+ this.hooks = {\n+ __proto__: null,\n+ before: [],\n+ after: [],\n+ ...
2023-04-23T17:55:01
facebook/react
6b3d86a2e92fdb79dedf05b759860bd7fd911222
82ef450e0e22ef3d5cff03d26aed7d708fa10537
Fixed bug in react-detools-inline frontend init method (#21265)
[ { "path": "packages/react-devtools-core/package.json", "patch": "@@ -1,6 +1,6 @@\n {\n \"name\": \"react-devtools-core\",\n- \"version\": \"4.12.0\",\n+ \"version\": \"4.12.1\",\n \"description\": \"Use react-devtools outside of the browser\",\n \"license\": \"MIT\",\n \"main\": \"./dist/backend.j...
2021-04-14T17:27:21
golang/go
1b4f1dc95d221c1e9d0afb9067fd6a09f12dd061
72e2220b50db5179ddca2226a64bf1d3aa94f49a
os: improve newFile, rm newDir 1. Assuming that CI environments do not use NFS (and if they do, they have TMPDIR set pointing to a local file system), we can - remove localTmp; - remove newDir, replacing calls to it with t.TempDir; - remove repeated comments about NFS. 2. Use t.Name, t.Cleanup and t.Helper to ...
[ { "path": "src/os/os_test.go", "patch": "@@ -158,28 +158,20 @@ func equal(name1, name2 string) (r bool) {\n \treturn\n }\n \n-// localTmp returns a local temporary directory not on NFS.\n-func localTmp() string {\n-\tswitch runtime.GOOS {\n-\tcase \"android\", \"ios\", \"windows\":\n-\t\treturn TempDir()\n-...
2024-06-12T00:25:06
vercel/next.js
3bd112b525584dc5e93b2f16ffc10db2b8f25f3c
88cdbae646f66c6ed3889c4db5745365450e9790
Turbopack: Implement build worker (#75391) ## What? Runs Turbopack in a separate child process so that e.g. memory usage can be cleaned up before continuing with the rest of the Next.js build. This will lower the peak memory consumption given that before this change the Turbopack cache was kept around until the ...
[ { "path": "packages/next/src/build/index.ts", "patch": "@@ -1389,7 +1389,7 @@ export default async function build(\n duration: compilerDuration,\n shutdownPromise: p,\n ...rest\n- } = await turbopackBuild(false)\n+ } = await turbopackBuild(true)\n ...
2025-01-29T12:27:01
electron/electron
7f1e3ca3def6d8beb9d444f805c508dc91294b2e
7ddc756a08b5575f2861ecaff1df5eb868fc534c
fix: shutdown crash in DownloadItem callback (#27342) The call stack for one of our top crashes looks like this: ``` node::Abort (node_errors.cc:241) node::Assert (node_errors.cc:256) node::MakeCallback (callback.cc:226) gin_helper::internal::CallMethodWithArgs (event_emitter_caller.cc:23) gin_helper::EmitEven...
[ { "path": "shell/browser/electron_browser_main_parts.cc", "patch": "@@ -520,6 +520,16 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() {\n FreeAppDelegate();\n #endif\n \n+ // Shutdown the DownloadManager before destroying Node to prevent\n+ // DownloadItem callbacks from crashing.\n+ for (au...
2021-01-20T19:30:08